<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">LGTM.<div><br><div><div>On Feb 17, 2011, at 2:52 AM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">And a follow-up that adds a bunch more tests and functionality to this checker. Specifically, it catches several C++ constructs and simple member variable uses. This incorporates the last of the functionality that we had implemented in our parallel work on the array bounds check warning.<div>
<br></div><div>Note that I still need to clean up a couple of tests in the suite which are actually triggering this warning. =] Not really interesting for the review though.<br><br><div class="gmail_quote">On Thu, Feb 17, 2011 at 12:25 AM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hey Ted,<div><br></div><div>I was working on merging in some of the extra checking logic our version had, and wanted to send a separate patch just for style cleanups. This should have no functionality changed, it just uses what I think are clearer and more consistent names in LLVM/Clang and reflows the code a bit to make the various branches a bit easier for me to follow. This look good to you?</div>
</blockquote></div><br></div>
<span><enhance-array-checking.patch></span></blockquote></div><br></div></body></html>