[cfe-commits] Wrong parameter names?

Douglas Gregor dgregor at apple.com
Thu Jan 27 10:31:46 PST 2011


On Jan 27, 2011, at 10:22 AM, Enea Zaffanella wrote:

> It seems to me that the ASTContext methods for creating array types are
> misnaming one of their parameters (see attached patch): they call
> EltTyQuals what actually should be the IndexTypeQuals.
> 
> This seems just to be a naming issue, since afaict all of the callers of
> these methods are not misguided by the wrong parameter name and
> correctly pass in the index qualifiers. Anyway, I suggest to
> double-check this code for potential issues that I may have missed.

Looks good, please go ahead and commit!

	- Doug



More information about the cfe-commits mailing list