[cfe-commits] Wrong parameter names?

Enea Zaffanella zaffanella at cs.unipr.it
Thu Jan 27 10:22:25 PST 2011


It seems to me that the ASTContext methods for creating array types are
misnaming one of their parameters (see attached patch): they call
EltTyQuals what actually should be the IndexTypeQuals.

This seems just to be a naming issue, since afaict all of the callers of
these methods are not misguided by the wrong parameter name and
correctly pass in the index qualifiers. Anyway, I suggest to
double-check this code for potential issues that I may have missed.

Enea.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: IndexQuals.patch
Type: text/x-patch
Size: 6059 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110127/92d1af09/attachment.bin>


More information about the cfe-commits mailing list