[cfe-commits] [PATCH] Inline asm mult-alt constraints changes and tests, Clang-side

Dale Johannesen dalej at apple.com
Tue Nov 2 13:45:32 PDT 2010

> +    case 'z':  // First SSE register.

This one isn't in gcc-4.2, it was added later.   OK unless we think it's covered by GPL3 somehow?  I don't see how, but IANAL.

> +      Name++;

This doesn't  currently accomplish anything.  From the tests I see handling "Y?" is a work in progress, so OK if you have a plan in mind for how to use it.

> +  case 'I': // Integer constant in the range 0..31 for 32-bit shifts.
> +  case 'J': // Integer constant in the range 0..63 for 64-bit shifts.
> +  case 'K': // 8-bit signed integer constant.
> +  case 'L': // 0xff or 0xffff, for andsi as a zero-extending move.
> +  case 'M': // 0, 1, 2, 3 (shifts for the lea instruction).
> +  case 'N': // Unsigned 8-bit integer constant (for in and out instructions).

These are recognized by the generic code in validateInputConstraint, we shouldn't duplicate that here.

Testcases are OK (assuming they pass)

On Nov 2, 2010, at 11:41 AMPDT, John Thompson wrote:

> May I check in the changes in the enclosed patch?
> I added a few constraint characters for x86 from the gcc docs, and two new test files for validating the .ll output with respect to mult-alt constraints.
> Thanks.
> -John
> -- 
> John Thompson
> John.Thompson.JTSoftware at gmail.com
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101102/251aed9c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clangmultalt10.patch
Type: application/octet-stream
Size: 20796 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101102/251aed9c/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101102/251aed9c/attachment-0001.html>

More information about the cfe-commits mailing list