<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><blockquote type="cite">+ case 'z': // First SSE register.</blockquote></div><div><br></div><div>This one isn't in gcc-4.2, it was added later. OK unless we think it's covered by GPL3 somehow? I don't see how, but IANAL.</div><div><br></div><div><div><blockquote type="cite">+ Name++;</blockquote></div><div><br></div></div><div>This doesn't currently accomplish anything. From the tests I see handling "Y?" is a work in progress, so OK if you have a plan in mind for how to use it.</div><div><br></div><div><div></div></div><blockquote type="cite"><div><div>+ case 'I': // Integer constant in the range 0..31 for 32-bit shifts.</div><div>+ case 'J': // Integer constant in the range 0..63 for 64-bit shifts.</div><div>+ case 'K': // 8-bit signed integer constant.</div><div>+ case 'L': // 0xff or 0xffff, for andsi as a zero-extending move.</div><div>+ case 'M': // 0, 1, 2, 3 (shifts for the lea instruction).</div><div>+ case 'N': // Unsigned 8-bit integer constant (for in and out instructions).</div></div></blockquote><div><br></div><div>These are recognized by the generic code in validateInputConstraint, we shouldn't duplicate that here.</div><div><br></div><div>Testcases are OK (assuming they pass)</div><div><br></div><div><div>On Nov 2, 2010, at 11:41 AMPDT, John Thompson wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>May I check in the changes in the enclosed patch?</div>
<div> </div>
<div>I added a few constraint characters for x86 from the gcc docs, and two new test files for validating the .ll output with respect to mult-alt constraints.</div>
<div> </div>
<div>Thanks.</div>
<div> </div>
<div>-John<br clear="all"><br>-- <br>John Thompson<br><a href="mailto:John.Thompson.JTSoftware@gmail.com">John.Thompson.JTSoftware@gmail.com</a><br><br></div>
</blockquote></div></body></html>