[cfe-commits] [PATCH] CFG initializers

Zhongxing Xu xuzhongxing at gmail.com
Sun Oct 3 18:10:35 PDT 2010


Looks great.

Minor nits:

* LLVM coding style uses 'SomeClass *A' instead of 'SomeClass* A'.

* +  // For C++ constructor add initializers to CFG.
+  if (const CXXConstructorDecl *CD =
dyn_cast_or_null<CXXConstructorDecl>(D)) {
+    for (CXXConstructorDecl::init_const_reverse_iterator I =
CD->init_rbegin()
+        , E = CD->init_rend(); I != E; ++I) {

Please put the comma at the end of the line.

+      B = addInitializer(*I);
+      if (badCFG)
+        return NULL;
+    }
+  }

2010/10/4 Marcin Świderski <marcin.sfider at gmail.com>

> Patch adds support for C++ initializers in constructors. The output is
> similar to the one generated for VarDecls. I've also added two simple test
> cases.
>
> Please approve for commit.
>
> Marcin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101004/3f0bfb4c/attachment.html>


More information about the cfe-commits mailing list