[cfe-commits] [win32][review request] clang Index test fix
Francois Pichet
pichet2000 at gmail.com
Sun Oct 3 17:50:00 PDT 2010
This patch remove the Win32 XFAIL from test/Index/remap-complete.c and
test/Index/remap-load.c
The problem was that text files were open in text mode and Microsoft
implementation of fread and write will try to do nasty line-feed
conversion which make the line position no longer valid.
I think the option llvm::raw_fd_ostream::F_Binary should always be
used. Or it should be removed and always applied. Or else we are going
to have more problem with that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: index_test_win_fix.patch
Type: application/octet-stream
Size: 2276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20101003/1619009a/attachment.obj>
More information about the cfe-commits
mailing list