[cfe-commits] r110440 - in /cfe/trunk: include/clang/Lex/HeaderSearch.h lib/Lex/HeaderSearch.cpp lib/Lex/PPDirectives.cpp test/Frontend/stdin2.c

Chris Lattner clattner at apple.com
Fri Aug 6 14:21:59 PDT 2010

On Aug 6, 2010, at 2:04 PM, Douglas Gregor wrote:

>> Did you do any performance checking of this?  HeaderSearch::LookupFile is incredibly performance sensitive for certain things (e.g. building cocoa.h pch file) and this patch probably just slowed it down by 3x.
> Hrm, I did not do any performance testing. I'll run some numbers in the morning and revert the patch if it causes an issue. Thanks for keeping an eye out; you know I aim to make Clang slow.

I think it's best to just revert this patch.  Using sys::Path isn't the right solution here from a design perspective anyway.  If you revert the patch I'll try to look at it again in the next couple weeks.


More information about the cfe-commits mailing list