[cfe-commits] r110440 - in /cfe/trunk: include/clang/Lex/HeaderSearch.h lib/Lex/HeaderSearch.cpp lib/Lex/PPDirectives.cpp test/Frontend/stdin2.c

[Douglas Gregor]

On Aug 6, 2010, at 11:02 PM, Chris Lattner wrote:

> 
> On Aug 6, 2010, at 5:06 AM, Douglas Gregor wrote:
> 
>> Author: dgregor
>> Date: Fri Aug  6 07:06:13 2010
>> New Revision: 110440
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=110440&view=rev
>> Log:
>> Fix the #include search path when reading from stdin, from Jon Simons!
>> Fixes PR4897.
> 
> hi Doug,
> 
> Did you do any performance checking of this?  HeaderSearch::LookupFile is incredibly performance sensitive for certain things (e.g. building cocoa.h pch file) and this patch probably just slowed it down by 3x.


Hrm, I did not do any performance testing. I'll run some numbers in the morning and revert the patch if it causes an issue. Thanks for keeping an eye out; you know I aim to make Clang slow.

	- Doug