[cfe-commits] r107953 - /cfe/trunk/lib/Basic/Targets.cpp

Eli Friedman eli.friedman at gmail.com
Thu Jul 8 22:55:17 PDT 2010

On Thu, Jul 8, 2010 at 10:02 PM, John Thompson
<john.thompson.jtsoftware at gmail.com> wrote:
> Eli,
> I've reverted it.
> But would you either please reconsider or give me an alternative solution?
> A comment in bug 7338 mentions input from Andrew Pinsky, who I think is one
> of the gcc guys, that gcc does ignore the commas.  But perhaps he just meant
> our PS3 gcc.  If so, perhaps I could do it only for the PS3 target, rather
> than for the PPC target, as I originally did?
> The code in question using the commas is in the PS3 SDK headers, meaning
> it's not so easy to change.

I don't think he meant gcc ignores commas in general, just that in
that particular case, the code is equivalent with and without commas.
The correct solution is not in platform specific code; it's something
like http://llvm.org/bugs/show_bug.cgi?id=7338#c6.  As a first
approximation, we could just chop off everything after the first comma
(which would be enough to work for PR7338).


More information about the cfe-commits mailing list