[cfe-commits] r107953 - /cfe/trunk/lib/Basic/Targets.cpp
john.thompson.jtsoftware at gmail.com
Thu Jul 8 22:02:25 PDT 2010
I've reverted it.
But would you either please reconsider or give me an alternative solution?
A comment in bug 7338 mentions input from Andrew Pinsky, who I think is one
of the gcc guys, that gcc does ignore the commas. But perhaps he just meant
our PS3 gcc. If so, perhaps I could do it only for the PS3 target, rather
than for the PPC target, as I originally did?
The code in question using the commas is in the PS3 SDK headers, meaning
it's not so easy to change.
On Thu, Jul 8, 2010 at 8:49 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Thu, Jul 8, 2010 at 7:01 PM, John Thompson
> <John.Thompson.JTSoftware at gmail.com> wrote:
> > Author: jtsoftware
> > Date: Thu Jul 8 21:01:40 2010
> > New Revision: 107953
> > URL: http://llvm.org/viewvc/llvm-project?rev=107953&view=rev
> > Log:
> > Updating PPC target to ignore commas in asm contrains, as apparently that
> is what gcc does.
> No, gcc does not ignore commas! Please revert.
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits