[cfe-commits] [PATCH] -ftabstop

[Christian Adåker]

On Tue, Jan 12, 2010 at 11:07 PM, Chris Lattner <clattner at apple.com> wrote:
> I think the driver should produce a warning on -ftabstop=0 or
> -ftabstop=10231231, not just silently ignore the error.  What do you think?

Of course it should. Especially now when I noticed a Diagnostic object
was so readily available. :) Fixed.

I also noticed that code modification hints are not printed properly
around tabs. I'll fix those as well.

//Christian
-------------- next part --------------
diff --git include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/DiagnosticDriverKinds.td
index efbc787..dfb6f8d 100644
--- include/clang/Basic/DiagnosticDriverKinds.td
+++ include/clang/Basic/DiagnosticDriverKinds.td
@@ -81,5 +81,7 @@ def warn_drv_clang_unsupported : Warning<
   "the clang compiler does not support '%0'">;
 def warn_drv_assuming_mfloat_abi_is : Warning<
   "unknown platform, assuming -mfloat-abi=%0">;
+def warn_ignoring_ftabstop_value : Warning<
+  "ignoring invalid -ftabstop value '%0', using default value %1">;
 
 }
diff --git include/clang/Frontend/DiagnosticOptions.h include/clang/Frontend/DiagnosticOptions.h
index 0220e64..13039bb 100644
--- include/clang/Frontend/DiagnosticOptions.h
+++ include/clang/Frontend/DiagnosticOptions.h
@@ -37,6 +37,7 @@ public:
 
   /// The distance between tab stops.
   unsigned TabStop;
+  enum { DefaultTabStop = 8, MaxTabStop = 100 };
 
   /// Column limit for formatting message diagnostics, or 0 if unused.
   unsigned MessageLength;
@@ -52,7 +53,7 @@ public:
 public:
   DiagnosticOptions() {
     IgnoreWarnings = 0;
-    TabStop = 8;
+    TabStop = DefaultTabStop;
     MessageLength = 0;
     NoRewriteMacros = 0;
     Pedantic = 0;
diff --git lib/Frontend/CompilerInvocation.cpp lib/Frontend/CompilerInvocation.cpp
index 375c75c..0bca475 100644
--- lib/Frontend/CompilerInvocation.cpp
+++ lib/Frontend/CompilerInvocation.cpp
@@ -222,7 +222,7 @@ static void DiagnosticOptsToArgs(const DiagnosticOptions &Opts,
     Res.push_back("-verify");
   if (Opts.ShowOptionNames)
     Res.push_back("-fdiagnostics-show-option");
-  if (Opts.TabStop != 8) {
+  if (Opts.TabStop != DiagnosticOptions::DefaultTabStop) {
     Res.push_back("-ftabstop");
     Res.push_back(llvm::utostr(Opts.TabStop));
   }
@@ -808,7 +808,13 @@ static void ParseDiagnosticArgs(DiagnosticOptions &Opts, ArgList &Args,
   Opts.ShowOptionNames = Args.hasArg(OPT_fdiagnostics_show_option);
   Opts.ShowSourceRanges = Args.hasArg(OPT_fdiagnostics_print_source_range_info);
   Opts.VerifyDiagnostics = Args.hasArg(OPT_verify);
-  Opts.TabStop = getLastArgIntValue(Args, OPT_ftabstop, 8, Diags);
+  Opts.TabStop = getLastArgIntValue(Args, OPT_ftabstop,
+                                    DiagnosticOptions::DefaultTabStop, Diags);
+  if (Opts.TabStop == 0 || Opts.TabStop > DiagnosticOptions::MaxTabStop) {
+    Diags.Report(diag::warn_ignoring_ftabstop_value)
+      << Opts.TabStop << DiagnosticOptions::DefaultTabStop;
+    Opts.TabStop = DiagnosticOptions::DefaultTabStop;
+  }
   Opts.MessageLength = getLastArgIntValue(Args, OPT_fmessage_length, 0, Diags);
   Opts.DumpBuildInformation = getLastArgValue(Args, OPT_dump_build_information);
   Opts.Warnings = getAllArgValues(Args, OPT_W);
diff --git lib/Frontend/TextDiagnosticPrinter.cpp lib/Frontend/TextDiagnosticPrinter.cpp
index c27d112..fcefd4e 100644
--- lib/Frontend/TextDiagnosticPrinter.cpp
+++ lib/Frontend/TextDiagnosticPrinter.cpp
@@ -371,15 +371,17 @@ void TextDiagnosticPrinter::EmitCaretDiagnostic(SourceLocation Loc,
     CaretLine.push_back('^');
 
   // Scan the source line, looking for tabs.  If we find any, manually expand
-  // them to 8 characters and update the CaretLine to match.
+  // them to spaces and update the CaretLine to match.
   for (unsigned i = 0; i != SourceLine.size(); ++i) {
     if (SourceLine[i] != '\t') continue;
 
     // Replace this tab with at least one space.
     SourceLine[i] = ' ';
 
-    unsigned TabStop = DiagOpts->TabStop > 0 ? DiagOpts->TabStop : 8;
     // Compute the number of spaces we need to insert.
+    unsigned TabStop = DiagOpts->TabStop;
+    assert(0 < TabStop && TabStop <= DiagnosticOptions::MaxTabStop &&
+           "Invalid -ftabstop value");
     unsigned NumSpaces = ((i+TabStop)/TabStop * TabStop) - (i+1);
     assert(NumSpaces < TabStop && "Invalid computation of space amt");