[cfe-commits] [PATCH] -ftabstop

[Chris Lattner]

On Jan 10, 2010, at 12:23 PM, Christian Adåker wrote:

> On Sat, Jan 9, 2010 at 10:54 PM, Chris Lattner <clattner at apple.com>  
> wrote:
>> Please improve it in two ways: 1) write a testcase, 2) reject - 
>> ftabstop=0, which will cause a division by zero error.  Thanks!
>>
>> -Chris
>
> Here is a test case, and a patch for checking that the TabStop value
> is in a reasonable range (having an upper limit stops -ftabstop=-1
> from consuming all available memory).
>
> //Christian
> <ftabstop-test.diff><ftabstop-range.diff>

Thanks! I applied the testcase in r93260.

I think the driver should produce a warning on -ftabstop=0 or - 
ftabstop=10231231, not just silently ignore the error.  What do you  
think?

-Chris