[cfe-commits] r82559 - /cfe/trunk/lib/AST/RecordLayoutBuilder.cpp

[Anders Carlsson]

On Sep 22, 2009, at 11:58 AM, Mike Stump wrote:

>
> On Sep 22, 2009, at 11:23 AM, Anders Carlsson wrote:
>
>>
>> On Sep 22, 2009, at 10:38 AM, Mike Stump wrote:
>>
>>> Author: mrs
>>> Date: Tue Sep 22 12:38:02 2009
>>> New Revision: 82559
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=82559&view=rev
>>> Log:
>>> Yes.
>>>
>>
>> Thanks for the clarification. The reason I added the FIXME was that  
>> the ABI spec say:
>>
>> Identify all virtual base classes, direct or indirect, that are  
>> primary base classes for some other direct or indirect base class.  
>> Call these indirect primary base classes.
>
> And doesn't this match:
>
>  /// VBases - direct and indirect virtual base classes of this class.
>  CXXBaseSpecifier *VBases;
>
> ?

It sure does! I was under the impression that VBases were just the  
direct virtual bases. Can we come up with a better name that indicates  
that it's all virtual bases?

Thanks,
Anders

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20090922/ecca0c9b/attachment.html>