[cfe-commits] r82559 - /cfe/trunk/lib/AST/RecordLayoutBuilder.cpp

[Mike Stump]

On Sep 22, 2009, at 11:23 AM, Anders Carlsson wrote:

>
> On Sep 22, 2009, at 10:38 AM, Mike Stump wrote:
>
>> Author: mrs
>> Date: Tue Sep 22 12:38:02 2009
>> New Revision: 82559
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=82559&view=rev
>> Log:
>> Yes.
>>
>
> Thanks for the clarification. The reason I added the FIXME was that  
> the ABI spec say:
>
> Identify all virtual base classes, direct or indirect, that are  
> primary base classes for some other direct or indirect base class.  
> Call these indirect primary base classes.

And doesn't this match:

   /// VBases - direct and indirect virtual base classes of this class.
   CXXBaseSpecifier *VBases;

?

> and the check made me believe that we were just looking for direct  
> virtual base classes.

Certainly any doc that can be refined with order information, direct/ 
non-direct, virtual/non-virtual and so on should be.  I fixed the doc  
for VBases, but others (getNumVBases, vbases_begin) are less helpful.