[cfe-commits] r79743 - in /cfe/trunk: lib/Sema/SemaExpr.cpp test/Sema/compare.c

[Mike Stump]

On Aug 22, 2009, at 4:08 PM, Eli Friedman wrote:

> On Sat, Aug 22, 2009 at 11:58 AM, Chris Lattner<sabre at nondot.org>  
> wrote:
>> Author: lattner
>> Date: Sat Aug 22 13:58:31 2009
>> New Revision: 79743
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=79743&view=rev
>> Log:
>> tweak some pointer sema checking stuff (which was added to  
>> implement PR4175) to
>> avoid emitting a warning on "someptr > 0".  This is obviously  
>> questionable (they
>> could use != instead) but is reasonable, and the warning "ordered  
>> comparison
>> between pointer and integer" didn't make a ton of sense because 0  
>> is a valid
>> null pointer constant.
>
> Sure, but the standard requires us to warn... it would be okay to
> split it into a separate warning, though.

I'm sure you and Chris understand the standard, but for those that are  
less familiar with it:

        [#1]   An  implementation  may  generate  warnings  in  many
        situations, none of which are  specified  as  part  of  this |
        International Standard.

The standard requires diagnostics, not warnings.