[cfe-commits] r79745 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td test/SemaObjC/warn-superclass-method-mismatch.m

[Fariborz Jahanian]

Author: fjahanian
Date: Sat Aug 22 14:24:56 2009
New Revision: 79745

URL: http://llvm.org/viewvc/llvm-project?rev=79745&view=rev
Log:
Removed -Wundeclared-selector and -Wreadonly-setter-attrs from
-Wmost group (too noisy). Placed warning on parameter type
misatch between methods in sub and super class under
-Wsuper-class-method-mismatch (also too noisy).


Modified:
    cfe/trunk/include/clang/Basic/DiagnosticGroups.td
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
    cfe/trunk/test/SemaObjC/warn-superclass-method-mismatch.m

Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=79745&r1=79744&r2=79745&view=diff

==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Sat Aug 22 14:24:56 2009
@@ -97,6 +97,7 @@
 def ReadOnlySetterAttrs : DiagGroup<"readonly-setter-attrs">;
 def Reorder : DiagGroup<"reorder">;
 def UndeclaredSelector : DiagGroup<"undeclared-selector">;
+def SuperSubClassMismatch : DiagGroup<"super-class-method-mismatch">;
 def : DiagGroup<"variadic-macros">;
 def VectorConversions : DiagGroup<"vector-conversions">;      // clang specific
 def VolatileRegisterVar : DiagGroup<"volatile-register-var">;
@@ -137,9 +138,11 @@
     UnusedVariable,
     VectorConversions,
     VolatileRegisterVar,
-    ReadOnlySetterAttrs,
-    Reorder,
-    UndeclaredSelector
+    // FIXME. Too many errors (-Werror) in a key project.
+    // ReadOnlySetterAttrs,
+    Reorder
+    // FIXME. Too many errors (-Werror) in a key project.
+    // UndeclaredSelector
  ]>;
 
 // -Wall is -Wmost -Wparentheses

Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=79745&r1=79744&r2=79745&view=diff

==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Sat Aug 22 14:24:56 2009
@@ -2093,7 +2093,7 @@
 def warn_maynot_respond : Warning<"%0  may not respond to %1">;
 def warn_attribute_method_def : Warning<
   "method attribute can only be specified on method declarations">;
-def ext_typecheck_base_super : ExtWarn<
+def ext_typecheck_base_super : Warning<
   "method parameter type %0 does not match "
-  "super class method parameter type %1">;
+  "super class method parameter type %1">, InGroup<SuperSubClassMismatch>, DefaultIgnore;
 }

Modified: cfe/trunk/test/SemaObjC/warn-superclass-method-mismatch.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/warn-superclass-method-mismatch.m?rev=79745&r1=79744&r2=79745&view=diff

==============================================================================
--- cfe/trunk/test/SemaObjC/warn-superclass-method-mismatch.m (original)
+++ cfe/trunk/test/SemaObjC/warn-superclass-method-mismatch.m Sat Aug 22 14:24:56 2009
@@ -1,4 +1,4 @@
-// RUN: clang-cc  -fsyntax-only -verify %s
+// RUN: clang-cc  -fsyntax-only -Wsuper-class-method-mismatch -verify %s
 
 @interface Root
 -(void) method_r: (char)ch : (float*)f1 : (int*) x; // expected-note {{previous declaration is here}}