[cfe-commits] r64820 - in /cfe/trunk: include/clang/AST/Type.h lib/AST/ASTContext.cpp lib/AST/Type.cpp

[fjahanian]

On Feb 17, 2009, at 3:26 PM, Chris Lattner wrote:

>
> On Feb 17, 2009, at 1:45 PM, Fariborz Jahanian wrote:
>
>> Author: fjahanian
>> Date: Tue Feb 17 15:45:36 2009
>> New Revision: 64820
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=64820&view=rev
>> Log:
>> Simplified ExtQualType per Chris's feedback.
>
> Thanks Fariborz!
>
>> ///
>> class ExtQualType : public Type, public llvm::FoldingSetNode {
>
> This looks great!
>
> In ASTContext::getAddrSpaceQualType, please sure that asking for a  
> __weak addrspace(1) type works and only results in a single  
> ExtQualType node.  We should never have ExtQualType(ExtQualType 
> (type)), they should merge together.

Yes, my last patch does this. But there is still a problem using:

ExtQualType::Profile(ID, T.getTypePtr(), AddressSpace, T.getObjCGCAttr 
());
   void *InsertPos = 0;
   if (ExtQualType *EXTQy = ExtQualTypes.FindNodeOrInsertPos(ID,  
InsertPos))
     return QualType(EXTQy, 0);

I will demo the problem to you tomorrow.

- Fariborz



>
> Thanks for working on this,
>
> -Chris