[cfe-commits] r64820 - in /cfe/trunk: include/clang/AST/Type.h lib/AST/ASTContext.cpp lib/AST/Type.cpp

[Chris Lattner]

On Feb 17, 2009, at 1:45 PM, Fariborz Jahanian wrote:

> Author: fjahanian
> Date: Tue Feb 17 15:45:36 2009
> New Revision: 64820
>
> URL: http://llvm.org/viewvc/llvm-project?rev=64820&view=rev
> Log:
> Simplified ExtQualType per Chris's feedback.

Thanks Fariborz!

> ///
> class ExtQualType : public Type, public llvm::FoldingSetNode {

This looks great!

In ASTContext::getAddrSpaceQualType, please sure that asking for a  
__weak addrspace(1) type works and only results in a single  
ExtQualType node.  We should never have  
ExtQualType(ExtQualType(type)), they should merge together.

Thanks for working on this,

-Chris