[cfe-commits] r64627 - /cfe/trunk/lib/Analysis/RangeConstraintManager.cpp

[Ted Kremenek]

Zhongxing,

Thanks for clarifying.  I'll fix this later today.  It's great that  
RangeConstraintManager passes the tests, but I don't think it should  
be made the default until it has been tested more extensively when  
analyzing real programs.

Ted

On Feb 16, 2009, at 3:47 AM, Zhongxing Xu <xuzhongxing at gmail.com> wrote:

> We are still using RangeConstraintManager by default, because  
> UseRanges has default value 'true'. It shows that  
> RangeConstraintManager has already passed all regression tests.
>
> On Mon, Feb 16, 2009 at 5:19 PM, Ben Laurie <benl at google.com> wrote:
> On Mon, Feb 16, 2009 at 4:54 AM, Ted Kremenek <kremenek at apple.com>  
> wrote:
> > Author: kremenek
> > Date: Sun Feb 15 22:54:20 2009
> > New Revision: 64627
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=64627&view=rev
> > Log:
> > Do not register 'RangeConstraintManager' as the default  
> ConstraintManager.
>
> I should note that this didn't work, by the way.
>
> >
> > Modified:
> >    cfe/trunk/lib/Analysis/RangeConstraintManager.cpp
> >
> > Modified: cfe/trunk/lib/Analysis/RangeConstraintManager.cpp
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/RangeConstraintManager.cpp?rev=64627&r1=64626&r2=64627&view=diff
> >
> >  
> === 
> === 
> === 
> =====================================================================
> > --- cfe/trunk/lib/Analysis/RangeConstraintManager.cpp (original)
> > +++ cfe/trunk/lib/Analysis/RangeConstraintManager.cpp Sun Feb 15  
> 22:54:20 2009
> > @@ -461,8 +461,6 @@
> >   return new RangeConstraintManager(StateMgr);
> >  }
> >
> > -RegisterConstraintManager X(CreateRangeConstraintManager);
> > -
> >  const GRState*
> >  RangeConstraintManager::AssumeSymNE(const GRState* St, SymbolRef  
> sym,
> >                                     const llvm::APSInt& V, bool&  
> isFeasible) {
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20090216/f2d0959c/attachment.html>