<html><body bgcolor="#FFFFFF"><div>Zhongxing,</div><div><br></div><div>Thanks for clarifying. I'll fix this later today. It's great that RangeConstraintManager passes the tests, but I don't think it should be made the default until it has been tested more extensively when analyzing real programs.<br><br>Ted</div><div><br>On Feb 16, 2009, at 3:47 AM, Zhongxing Xu <<a href="mailto:xuzhongxing@gmail.com">xuzhongxing@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div>We are still using RangeConstraintManager by default, because UseRanges has default value 'true'. It shows that RangeConstraintManager has already passed all regression tests.<br><br><div class="gmail_quote">On Mon, Feb 16, 2009 at 5:19 PM, Ben Laurie <span dir="ltr"><<a href="mailto:benl@google.com"><a href="mailto:benl@google.com">benl@google.com</a></a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d">On Mon, Feb 16, 2009 at 4:54 AM, Ted Kremenek <<a href="mailto:kremenek@apple.com"><a href="mailto:kremenek@apple.com">kremenek@apple.com</a></a>> wrote:<br>
> Author: kremenek<br>
> Date: Sun Feb 15 22:54:20 2009<br>
> New Revision: 64627<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=64627&view=rev" target="_blank"><a href="http://llvm.org/viewvc/llvm-project?rev=64627&view=rev">http://llvm.org/viewvc/llvm-project?rev=64627&view=rev</a></a><br>
> Log:<br>
> Do not register 'RangeConstraintManager' as the default ConstraintManager.<br>
<br>
</div>I should note that this didn't work, by the way.<br>
<div><div></div><div class="Wj3C7c"><br>
><br>
> Modified:<br>
> cfe/trunk/lib/Analysis/RangeConstraintManager.cpp<br>
><br>
> Modified: cfe/trunk/lib/Analysis/RangeConstraintManager.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/RangeConstraintManager.cpp?rev=64627&r1=64626&r2=64627&view=diff" target="_blank"><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/RangeConstraintManager.cpp?rev=64627&r1=64626&r2=64627&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/RangeConstraintManager.cpp?rev=64627&r1=64626&r2=64627&view=diff</a></a><br>
><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Analysis/RangeConstraintManager.cpp (original)<br>
> +++ cfe/trunk/lib/Analysis/RangeConstraintManager.cpp Sun Feb 15 22:54:20 2009<br>
> @@ -461,8 +461,6 @@<br>
> return new RangeConstraintManager(StateMgr);<br>
> }<br>
><br>
> -RegisterConstraintManager X(CreateRangeConstraintManager);<br>
> -<br>
> const GRState*<br>
> RangeConstraintManager::AssumeSymNE(const GRState* St, SymbolRef sym,<br>
> const llvm::APSInt& V, bool& isFeasible) {<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu"><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a></a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></a><br>
><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu"><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a></a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></a><br>
</div></div></blockquote></div><br>
</div></blockquote></body></html>