[cfe-commits] r58110 - /cfe/trunk/lib/Analysis/GRExprEngine.cpp

[Ted Kremenek]

On Nov 14, 2008, at 8:29 PM, Zhongxing Xu wrote:

>
>
> On Sat, Nov 15, 2008 at 12:06 PM, Ted Kremenek <kremenek at apple.com>  
> wrote:
>
> On Nov 14, 2008, at 1:22 AM, Zhongxing Xu wrote:
>
>>
>>
>> On Sat, Oct 25, 2008 at 5:10 AM, Ted Kremenek <kremenek at apple.com>  
>> wrote:
>> Author: kremenek
>> Date: Fri Oct 24 16:10:49 2008
>> New Revision: 58110
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=58110&view=rev
>> Log:
>> Implicit conversions from arrays can also be conversions to  
>> references (will add a test case shortly).
>>
>> Hi Ted,
>>
>> Could you please point me to the test cast for this? Thanks.
>
> I'm no longer noticing a failure in the code bases I was scanning,  
> which could mean the problem was elsewhere.  I've re-enabled the  
> assertion (which looks correct to me).
>
> I guess you are referring to the assertion at GRExprEngine.cpp:873.  
> But I mean the assertion at GRExprEngine.cpp:1689 when we cast from  
> array to pointer. When could it be a reference type?

Yes; I was looking at the wrong assertion (although that cleanup was  
needed as well).  ;-)

I may have encountered that issue with varargs, but I'm not certain.   
I will remove the case for references and run it against the code base  
I think originally triggered the issue.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20081114/8168a2d7/attachment.html>