<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 14, 2008, at 8:29 PM, Zhongxing Xu wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><br><br><div class="gmail_quote">On Sat, Nov 15, 2008 at 12:06 PM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com">kremenek@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div style=""><br><div><div class="Ih2E3d"><div>On Nov 14, 2008, at 1:22 AM, Zhongxing Xu wrote:</div><br></div><div class="Ih2E3d"><blockquote type="cite"><span style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;"><br> <br><div class="gmail_quote">On Sat, Oct 25, 2008 at 5:10 AM, Ted Kremenek<span> </span><span dir="ltr"><<a href="mailto:kremenek@apple.com" target="_blank">kremenek@apple.com</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Author: kremenek<br>Date: Fri Oct 24 16:10:49 2008<br>New Revision: 58110<br><br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project?rev=58110&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=58110&view=rev</a><br> Log:<br>Implicit conversions from arrays can also be conversions to references (will add a test case shortly).</blockquote><div><br>Hi Ted,<br><br>Could you please point me to the test cast for this? Thanks.</div></div></span></blockquote> </div></div><br><div>I'm no longer noticing a failure in the code bases I was scanning, which could mean the problem was elsewhere. I've re-enabled the assertion (which looks correct to me). </div></div></blockquote> </div><br>I guess you are referring to the assertion at GRExprEngine.cpp:873. But I mean the assertion at GRExprEngine.cpp:1689 when we cast from array to pointer. When could it be a reference type?<br></blockquote></div><br><div>Yes; I was looking at the wrong assertion (although that cleanup was needed as well). ;-)</div><div><br></div><div>I may have encountered that issue with varargs, but I'm not certain. I will remove the case for references and run it against the code base I think originally triggered the issue.</div></body></html>