[all-commits] [llvm/llvm-project] 1e6f0c: [NFC][SemaHLSL][CGHLSL] Move semantic classificati...

[Finn Plummer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1e6f0cbabe1bce674eadb77814d98e2263823384
      https://github.com/llvm/llvm-project/commit/1e6f0cbabe1bce674eadb77814d98e2263823384
  Author: Finn Plummer <mail at inbelic.dev>
  Date:   2026-09-10 (Thu, 10 Sep 2026)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/include/clang/Sema/SemaHLSL.h
    M clang/lib/CodeGen/CGHLSLRuntime.cpp
    M clang/lib/CodeGen/CGHLSLRuntime.h
    M clang/lib/Sema/SemaHLSL.cpp
    M clang/test/CodeGenHLSL/semantics/DispatchThreadID-noindex.hlsl
    M clang/test/CodeGenHLSL/semantics/SV_GroupID-noindex.hlsl
    M clang/test/CodeGenHLSL/semantics/SV_GroupThreadID-noindex.hlsl
    M clang/test/CodeGenHLSL/semantics/SV_Position.ps.hlsl
    M clang/test/CodeGenHLSL/semantics/semantic.array.output.hlsl
    M clang/test/SemaHLSL/Availability/attr-availability-pixel.hlsl
    A clang/test/SemaHLSL/Semantics/arbitrary.ms.input.hlsl
    A clang/test/SemaHLSL/Semantics/arbitrary.ps.output.hlsl
    M clang/test/SemaHLSL/Semantics/groupindex.hlsl
    M clang/test/SemaHLSL/Semantics/invalid_entry_parameter.hlsl
    A clang/test/SemaHLSL/Semantics/output-parameters.hlsl
    M clang/test/SemaHLSL/Semantics/position.ps.hlsl
    M clang/test/SemaHLSL/Semantics/position.ps.struct.hlsl
    M clang/test/SemaHLSL/Semantics/position.ps.struct.reuse.hlsl
    A clang/test/SemaHLSL/Semantics/semantic-indexing.hlsl
    M clang/test/SemaHLSL/Semantics/target.ps.input.hlsl
    M clang/test/SemaHLSL/Semantics/target.vs.input.hlsl
    M clang/test/SemaHLSL/Semantics/target.vs.output.hlsl
    M clang/test/SemaHLSL/Semantics/vertexid.ps.hlsl
    M clang/test/SemaHLSL/num_threads.hlsl
    M clang/test/SemaHLSL/shader_type_attr.hlsl
    M llvm/include/llvm/Frontend/HLSL/SemanticSignatures.h
    M llvm/lib/Frontend/HLSL/SemanticSignatures.cpp
    M llvm/unittests/Frontend/CMakeLists.txt
    A llvm/unittests/Frontend/HLSLSemanticStagesTest.cpp

  Log Message:
  -----------
  [NFC][SemaHLSL][CGHLSL] Move semantic classification to common `HLSL/SemanticSignatures` (#218058)

Updates SemaHLSL and CGHLSL to not use stringref compares to distinguish
semantics and converts them to a common `SemanticKind` enum.

Further, it moves the classification of valid shader stages into a
common table to denote where a semantic is interpreted and how it is
used to to derive if it is valid.

This also updates tests that were using invalid semantic constructs to
use corrected versions.

This is a pre-req for the signature packing issues (#205875, etc) and
#189765

Assisted by: Claude Opus 5 and GPT-5.6 Sol



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications