[all-commits] [llvm/llvm-project] 0dedc9: [Support] Fix symbolizer markup backtrace; reenabl...

[Daniel Thornburgh via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0dedc9511bca8038ef0386225b97c867037f45bb
      https://github.com/llvm/llvm-project/commit/0dedc9511bca8038ef0386225b97c867037f45bb
  Author: Daniel Thornburgh <dthorn at google.com>
  Date:   2026-06-05 (Fri, 05 Jun 2026)

  Changed paths:
    M llvm/lib/Support/Unix/Signals.inc
    M llvm/unittests/Support/SignalsTest.cpp

  Log Message:
  -----------
  [Support] Fix symbolizer markup backtrace; reenable test (#181035)

The symbolizer markup backtrace test depended on the binary having a
build ID; this isn't a given. Instead, we check to see if the binary
name is anywhere in the output string; if not, we skip the test. This
isn't perfect of course, but determining whether the binary under test
overlaps contains a build ID overlaps too much with the implementation
of the feature; this at least keeps the tests independent.

The above fix uncovered an issue: the build ID of another DSO would be
misattributed to the main DSO if the main DSO had no build ID. This
issue has been corrected also.

Fixes #168891



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications