[all-commits] [llvm/llvm-project] 2f9f70: [AArch64][llvm] Tighten SYSP; don't disassemble in...

[Jonathan Thackray via All-commits]

  Branch: refs/heads/users/jthackray/tighten_sysp_encoding
  Home:   https://github.com/llvm/llvm-project
  Commit: 2f9f70cc57fccef8b856ea0888277299c8a568ef
      https://github.com/llvm/llvm-project/commit/2f9f70cc57fccef8b856ea0888277299c8a568ef
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M lldb/test/Shell/Commands/command-disassemble-aarch64-color.s
    M lldb/test/Shell/Commands/command-disassemble-aarch64-extensions.s
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s
    A llvm/test/MC/AArch64/armv9-sysp-invalid.s
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  [AArch64][llvm] Tighten SYSP; don't disassemble invalid encodings

Tighten SYSP aliases, so that invalid encodings are disassembled
to `<unknown>`. This is because:

```
  Cn is a 4-bit unsigned immediate, in the range 8 to 9
  Cm is a 4-bit unsigned immediate, in the range 0 to 7
  op1 is a 3-bit unsigned immediate, in the range 0 to 6
  op2 is a 3-bit unsigned immediate, in the range 0 to 7
```

Ensure we check this when disassembling, and also constrain
tablegen for compile-time errors of invalid encodings.

Also adjust the testcases in `armv9-sysp-diagnostics.s` and
`llvm/test/MC/AArch64/armv9a-sysp.s` as they were invalid,
and added a few invalid (outside of range) SYSP-alikes to
test that `<unknown>` is printed


  Commit: df0c44643ef5d434b3b4486e49c37753a0e3b05b
      https://github.com/llvm/llvm-project/commit/df0c44643ef5d434b3b4486e49c37753a0e3b05b
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td

  Log Message:
  -----------
  fixup! Address Marian's PR comments: use imm0_6 predicate


  Commit: b2385f6ff0c2fff651d620e8a39d8522f429c5d4
      https://github.com/llvm/llvm-project/commit/b2385f6ff0c2fff651d620e8a39d8522f429c5d4
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s

  Log Message:
  -----------
  fixup! Templatise bounds checking and improve tests


  Commit: 53c63dfa622b34e0ba51c14a91e029f816859419
      https://github.com/llvm/llvm-project/commit/53c63dfa622b34e0ba51c14a91e029f816859419
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td
    M llvm/lib/Target/AArch64/AArch64RegisterInfo.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.h
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s
    R llvm/test/MC/AArch64/armv9-sysp-invalid.s
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  fixup! Remove SYSPxt_XZR and update code to reflect this


  Commit: ab417f0171f94befa1e3760b69762c8a394b66fb
      https://github.com/llvm/llvm-project/commit/ab417f0171f94befa1e3760b69762c8a394b66fb
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
    M llvm/test/MC/AArch64/armv9a-sysp.s

  Log Message:
  -----------
  fixup! Add no-alias tests


  Commit: 1b01e4161fd082118165e339cc44c7bf451574d2
      https://github.com/llvm/llvm-project/commit/1b01e4161fd082118165e339cc44c7bf451574d2
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s

  Log Message:
  -----------
  fixup! Address PR comments


  Commit: 6a153ec0cfa746886d09e67f93c0ccacf99e3ccd
      https://github.com/llvm/llvm-project/commit/6a153ec0cfa746886d09e67f93c0ccacf99e3ccd
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td

  Log Message:
  -----------
  fixup! Fixes after rebasing following Marian's change


  Commit: 435869a14836676b63b083c72427ba647743e4a4
      https://github.com/llvm/llvm-project/commit/435869a14836676b63b083c72427ba647743e4a4
  Author: Jonathan Thackray <jonathan.thackray at arm.com>
  Date:   2026-03-24 (Tue, 24 Mar 2026)

  Changed paths:
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/test/MC/AArch64/armv9-sysp-diagnostics.s

  Log Message:
  -----------
  fixup! Improve error parsing


Compare: https://github.com/llvm/llvm-project/compare/4c92f03fcf0a...435869a14836

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications