[all-commits] [llvm/llvm-project] f52859: [MC] Fix accidentally eating the newline when hand...

[Amara Emerson via All-commits]

  Branch: refs/heads/users/amara/asmlexer-comment
  Home:   https://github.com/llvm/llvm-project
  Commit: f528592fdd3c970770b092d55b5b24bcca63d59d
      https://github.com/llvm/llvm-project/commit/f528592fdd3c970770b092d55b5b24bcca63d59d
  Author: Amara Emerson <amara at apple.com>
  Date:   2025-10-25 (Sat, 25 Oct 2025)

  Changed paths:
    M llvm/lib/MC/MCParser/AsmLexer.cpp
    A llvm/test/MC/AsmParser/comments-x86-darwin-eol-dropped.s

  Log Message:
  -----------
  [MC] Fix accidentally eating the newline when handling a comment char at the end of the line.

If we have a target where both # and ## are valid comment strings,
a line ending in # would trigger the lexer to eat 2 characters
and therefore lex the *next* line as a comment. Oops. This was introduced
in 4946db15a74b761c5ac4ead18873639236b4ab5d



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications