[all-commits] [llvm/llvm-project] fd756c: [ARM] Fix not saving FP when required to in frame-...

[Amara Emerson via All-commits]

  Branch: refs/heads/users/amara/asmlexer-comment
  Home:   https://github.com/llvm/llvm-project
  Commit: fd756cbd6eb335024239221a3ca98e201ac02798
      https://github.com/llvm/llvm-project/commit/fd756cbd6eb335024239221a3ca98e201ac02798
  Author: Amara Emerson <amara at apple.com>
  Date:   2025-10-25 (Sat, 25 Oct 2025)

  Changed paths:
    M llvm/lib/Target/ARM/ARMFrameLowering.cpp
    A llvm/test/CodeGen/ARM/save-fp-with-non-leaf.ll

  Log Message:
  -----------
  [ARM] Fix not saving FP when required to in frame-pointer=non-leaf.

When the stars align to conspire against stack alignment, when we have
frame-pointer=non-leaf we can incorrectly skip preserving fp/r7 in the prolog.
The fix here first makes sure we're using the right frame pointer register in
the context of preserving the incoming FP, and then make sure that we save
the FP when re-alignment is known to be necessary.

rdar://162462271


  Commit: 07be0d30a8b866755c9420dcdad7b75ed20ed626
      https://github.com/llvm/llvm-project/commit/07be0d30a8b866755c9420dcdad7b75ed20ed626
  Author: Amara Emerson <amara at apple.com>
  Date:   2025-10-25 (Sat, 25 Oct 2025)

  Changed paths:
    M llvm/lib/MC/MCParser/AsmLexer.cpp
    A llvm/test/MC/AsmParser/comments-x86-darwin-eol-dropped.s

  Log Message:
  -----------
  [MC] Fix accidentally eating the newline when handling a comment char at the end of the line.

If we have a target where both # and ## are valid comment strings,
a line ending in # would trigger the lexer to eat 2 characters
and therefore lex the *next* line as a comment. Oops. This was introduced
in 4946db15a74b761c5ac4ead18873639236b4ab5d


Compare: https://github.com/llvm/llvm-project/compare/fd756cbd6eb3%5E...07be0d30a8b8

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications