[all-commits] [llvm/llvm-project] a6fb3b: [LLDB] Process minidump better error messages (#14...
Jacob Lalonde via All-commits
all-commits at lists.llvm.org
Thu Jul 17 09:18:44 PDT 2025
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: a6fb3b3c18fd48a2eaaa8c969edbc013b9276a09
https://github.com/llvm/llvm-project/commit/a6fb3b3c18fd48a2eaaa8c969edbc013b9276a09
Author: Jacob Lalonde <jalalonde at fb.com>
Date: 2025-07-17 (Thu, 17 Jul 2025)
Changed paths:
M lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
M lldb/source/Plugins/Process/minidump/MinidumpParser.h
M lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
A lldb/test/Shell/Minidump/missing-memory-region.yaml
M lldb/unittests/Process/minidump/MinidumpParserTest.cpp
Log Message:
-----------
[LLDB] Process minidump better error messages (#149206)
Prior, Process Minidump would return
```
Status::FromErrorString("could not parse memory info");
```
For any unsuccessful memory read, with no differentiation between an
error in LLDB and the data simply not being present. This lead to a lot
of user confusion and overall pretty terrible user experience. To fix
this I've refactored the APIs so we can pass an error back in an llvm
expected.
There were also no shell tests for memory read and process Minidump so I
added one.
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list