[all-commits] [llvm/llvm-project] d78036: Only restart failed libc++ jobs, not cancelled one...

[Eric via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d78036f06ea94a42b7cff62241e91ed5b2900c7a
      https://github.com/llvm/llvm-project/commit/d78036f06ea94a42b7cff62241e91ed5b2900c7a
  Author: Eric <eric at efcs.ca>
  Date:   2025-07-02 (Wed, 02 Jul 2025)

  Changed paths:
    M .github/workflows/libcxx-restart-preempted-jobs.yaml

  Log Message:
  -----------
  Only restart failed libc++ jobs, not cancelled ones. (#146397)

Despite the error message for preempted jobs containing the words
"cancelled", these are considered workflow "failures" by github.

This is important, because if we fail to distinguish between "failed"
and "cancelled" jobs, the restarter will fight to restart jobs a user
intentionally cancelled (either by pressing the "cancel" button, or by
pushing an update to a PR).

This reverts commit 3ea7fc73397032e71fb20d27084f4552211bb1f6. This also
reverts earlier attempts to solve this problem by matching the messages
to detect manual cancellations.

This change also removes ldionne's test workflow, as its hard to
correctly keep in sync.

This change does not attempt to address the maintainability or
testability of this script, which continues to be an issue. If asked to
address these issues, my plan is to write the script in python (which
most people are more familar with), and turn this action into a "docker
action" using a container with the python action and dependencies built
into it. Let me know if that's a direction we're interested in heading.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications