[all-commits] [llvm/llvm-project] a63030: [OpenACC] unify reduction and private-like init re...

[Scott Manley via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a6303099fde64875ded9a4fb807abc907cb80629
      https://github.com/llvm/llvm-project/commit/a6303099fde64875ded9a4fb807abc907cb80629
  Author: Scott Manley <rscottmanley at gmail.com>
  Date:   2025-05-20 (Tue, 20 May 2025)

  Changed paths:
    M flang/include/flang/Lower/OpenACC.h
    M flang/lib/Lower/OpenACC.cpp
    M flang/test/Lower/OpenACC/acc-reduction.f90
    M mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td

  Log Message:
  -----------
  [OpenACC] unify reduction and private-like init region recipes (#140652)

Between firstprivate, private and reduction init regions, the difference
is largely whether or not the temp that is created is initialized or
not. Some recent fixes were made to privatization (#135698, #137869) but
did not get propagated to reductions, even though they need to return
the yield the same things from their init regions.

To mitigate this discrepancy in the future, refactor the init region
recipes so they can be shared between the three recipe ops.

Also add "none" to the OpenACC_ReductionOperator enum for better error
checking.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications