[all-commits] [llvm/llvm-project] ec6828: [lldb-dap] Remove an incorrect assumption on rever...

[John Harrison via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ec6828c1ecad7fe2f799f7b5af3361885a5d5bb9
      https://github.com/llvm/llvm-project/commit/ec6828c1ecad7fe2f799f7b5af3361885a5d5bb9
  Author: John Harrison <harjohn at google.com>
  Date:   2025-04-19 (Sat, 19 Apr 2025)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
    M lldb/tools/lldb-dap/Protocol/ProtocolBase.cpp

  Log Message:
  -----------
  [lldb-dap] Remove an incorrect assumption on reverse requests. (#136210)

Reverse requests do have a 'seq' set still from VSCode. I incorrectly
interpreted
https://github.com/microsoft/vscode/blob/dede7bb4b7e9c9ec69155a243bb84037a40588fe/src/vs/workbench/contrib/debug/common/abstractDebugAdapter.ts#L65
to mean they have a 'seq' of '0', however the 'seq' is set in
'internalSend' here
https://github.com/microsoft/vscode/blob/dede7bb4b7e9c9ec69155a243bb84037a40588fe/src/vs/workbench/contrib/debug/common/abstractDebugAdapter.ts#L178.

Removing the check that 'seq=0' on reverse requests and updating the
dap_server.py impl to also set the seq.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications