[all-commits] [llvm/llvm-project] d35bf1: [HLSL] Add a warning for implicit bindings (#135909)

[Justin Bogner via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d35bf17e8a0cf37959149257c0eda7b9f912390e
      https://github.com/llvm/llvm-project/commit/d35bf17e8a0cf37959149257c0eda7b9f912390e
  Author: Justin Bogner <mail at justinbogner.com>
  Date:   2025-04-16 (Wed, 16 Apr 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticGroups.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Parse/ParseHLSL.cpp
    M clang/lib/Sema/SemaHLSL.cpp
    M clang/test/AST/HLSL/ByteAddressBuffers-AST.hlsl
    M clang/test/AST/HLSL/OutArgExpr.hlsl
    M clang/test/AST/HLSL/StructuredBuffers-AST.hlsl
    M clang/test/AST/HLSL/TypedBuffers-AST.hlsl
    M clang/test/AST/HLSL/ast-dump-comment-cbuffer.hlsl
    M clang/test/AST/HLSL/cbuffer.hlsl
    M clang/test/AST/HLSL/cbuffer_and_namespaces.hlsl
    M clang/test/AST/HLSL/default_cbuffer.hlsl
    M clang/test/AST/HLSL/is_structured_resource_element_compatible_concept.hlsl
    M clang/test/AST/HLSL/is_typed_resource_element_compatible_concept.hlsl
    M clang/test/AST/HLSL/packoffset.hlsl
    M clang/test/AST/HLSL/pch.hlsl
    M clang/test/AST/HLSL/pch_hlsl_buffer.hlsl
    M clang/test/AST/HLSL/pch_with_buf.hlsl
    M clang/test/AST/HLSL/private.hlsl
    M clang/test/CodeGenHLSL/GlobalConstructorLib.hlsl
    M clang/test/CodeGenHLSL/GlobalConstructors.hlsl
    M clang/test/CodeGenHLSL/builtins/AppendStructuredBuffer-elementtype.hlsl
    M clang/test/CodeGenHLSL/builtins/ConsumeStructuredBuffer-elementtype.hlsl
    M clang/test/CodeGenHLSL/builtins/RWBuffer-elementtype.hlsl
    M clang/test/CodeGenHLSL/builtins/RWBuffer-subscript.hlsl
    M clang/test/CodeGenHLSL/builtins/RWStructuredBuffer-elementtype.hlsl
    M clang/test/CodeGenHLSL/builtins/RasterizerOrderedStructuredBuffer-elementtype.hlsl
    M clang/test/CodeGenHLSL/builtins/StructuredBuffer-elementtype.hlsl
    M clang/test/CodeGenHLSL/builtins/StructuredBuffers-methods-ps.hlsl
    M clang/test/CodeGenHLSL/builtins/StructuredBuffers-subscripts.hlsl
    M clang/test/CodeGenHLSL/cbuffer.hlsl
    M clang/test/CodeGenHLSL/cbuffer_align.hlsl
    M clang/test/CodeGenHLSL/cbuffer_and_namespaces.hlsl
    M clang/test/CodeGenHLSL/cbuffer_with_static_global_and_function.hlsl
    M clang/test/CodeGenHLSL/default_cbuffer.hlsl
    M clang/test/CodeGenHLSL/default_cbuffer_with_layout.hlsl
    M clang/test/CodeGenHLSL/implicit-norecurse-attrib.hlsl
    M clang/test/CodeGenHLSL/inline-functions.hlsl
    M clang/test/CodeGenHLSL/static-local-ctor.hlsl
    M clang/test/ParserHLSL/cb_error.hlsl
    M clang/test/ParserHLSL/hlsl_is_rov_attr_error.hlsl
    M clang/test/ParserHLSL/hlsl_raw_buffer_attr_error.hlsl
    M clang/test/ParserHLSL/hlsl_resource_class_attr.hlsl
    M clang/test/ParserHLSL/hlsl_resource_handle_attrs.hlsl
    M clang/test/ParserHLSL/invalid_inside_cb.hlsl
    M clang/test/SemaHLSL/BuiltIns/RWBuffers.hlsl
    M clang/test/SemaHLSL/BuiltIns/StructuredBuffers.hlsl
    M clang/test/SemaHLSL/BuiltIns/hlsl_resource_t.hlsl
    M clang/test/SemaHLSL/Language/AggregateSplatCast-errors.hlsl
    M clang/test/SemaHLSL/cb_error.hlsl
    M clang/test/SemaHLSL/export.hlsl
    M clang/test/SemaHLSL/packoffset-invalid.hlsl
    M clang/test/SemaHLSL/resource_binding_attr_error.hlsl
    M clang/test/SemaHLSL/resource_binding_attr_error_basic.hlsl
    M clang/test/SemaHLSL/resource_binding_attr_error_resource.hlsl
    M clang/test/SemaHLSL/resource_binding_attr_error_silence_diags.hlsl
    M clang/test/SemaHLSL/resource_binding_attr_error_space.hlsl
    M clang/test/SemaHLSL/resource_binding_attr_error_udt.hlsl
    A clang/test/SemaHLSL/resource_binding_implicit.hlsl

  Log Message:
  -----------
  [HLSL] Add a warning for implicit bindings (#135909)

Implicit bindings will cause very confusing crashes in the backend at
present, so this is intended at least partially as a stop gap until we
get them implemented (see #110722).

However, I do think that this is useful in the longer term as well as an
off-by-default warning, as it is quite easy to miss a binding or two
when using explicit bindings and the results of that can be surprisingly
hard to debug. I've filed #135907 to track turning this into an
off-by-default warning or removing it eventually as we see fit.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications