[all-commits] [llvm/llvm-project] 1a7402: [NFC][Driver][HIP] Fix mixing `amdgcnspirv` and `g...

Alex Voicu via All-commits all-commits at lists.llvm.org
Wed Mar 26 03:06:43 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1a7402d3d831940fc04cc0fb5731239744ce5435
      https://github.com/llvm/llvm-project/commit/1a7402d3d831940fc04cc0fb5731239744ce5435
  Author: Alex Voicu <alexandru.voicu at amd.com>
  Date:   2025-03-26 (Wed, 26 Mar 2025)

  Changed paths:
    M clang/lib/Driver/Driver.cpp
    M clang/test/Driver/hip-toolchain-no-rdc.hip

  Log Message:
  -----------
  [NFC][Driver][HIP] Fix mixing `amdgcnspirv` and `gfxXXX` via `--offload-arch` (#133024)

Due to `amdgcnspirv` piggybacking on the HIPAMDToolchain, it loses its
immediately apparent SPIR-Vness, which makes the Driver want to go all
the way to Assembly emmission. This was problematic as we were trying to
`llvm-link` SPIR-V, before trying to translate it. This patch ensures
that we do the right thing and stop at bitcode emission if we are mixing
`amdgcnspirv` and concrete targets.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list