[all-commits] [llvm/llvm-project] 6542cf: [lldb/platform-gdb] Do not assume a persistent con...

[Igor Kudrin via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6542cf1973208a83b2f883f2143464c4fdbac9eb
      https://github.com/llvm/llvm-project/commit/6542cf1973208a83b2f883f2143464c4fdbac9eb
  Author: Igor Kudrin <ikudrin at accesssoftek.com>
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
    M lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
    M lldb/unittests/Platform/CMakeLists.txt
    A lldb/unittests/Platform/gdb-server/CMakeLists.txt
    A lldb/unittests/Platform/gdb-server/PlatformRemoteGDBServerTest.cpp

  Log Message:
  -----------
  [lldb/platform-gdb] Do not assume a persistent connection (#131736)

After https://reviews.llvm.org/D116539, when `m_gdb_client_up` in
`PlatformRemoteGDBServer` is not null, the connection to a server is
expected to exist. However,
`PlatformRemoteGDBServer::DisconnectRemote()` is not the only way to
close the connection;
`GDBRemoteCommunication::WaitForPacketNoLock()` can disconnect if the
server stops responding, and in this case `m_gdb_client_up` is not
cleared. The patch removes this assumption and checks the connection
status directly.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications