[all-commits] [llvm/llvm-project] 194ece: update_test_checks: add new --filter-out-after opt...

David Sherwood via All-commits all-commits at lists.llvm.org
Tue Mar 18 02:47:04 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 194eceff4327912e6f9167478262961d50516750
      https://github.com/llvm/llvm-project/commit/194eceff4327912e6f9167478262961d50516750
  Author: David Sherwood <david.sherwood at arm.com>
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
    A clang/test/utils/update_cc_test_checks/Inputs/filter_out_after.c
    A clang/test/utils/update_cc_test_checks/Inputs/filter_out_after.c.expected
    A clang/test/utils/update_cc_test_checks/filter_out_after.test
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/filter-out-after.ll
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/filter-out-after.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/filter-out-after.ll.expected2
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/filter-out-after2.ll
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/filter-out-after2.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/filter-out-after3.ll
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/filter-out-after3.ll.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/filter_out_after.test
    M llvm/utils/UpdateTestChecks/common.py

  Log Message:
  -----------
  update_test_checks: add new --filter-out-after option (#129739)

Whilst trying to clean up some loop vectoriser IR tests (see
test/Transforms/LoopVectorize/AArch64/partial-reduce-chained.ll
for example) a reviewer on PR #129047 suggested it would be
nice to have an option to stop generating CHECK lines after a
certain point. Typically when performing a transformation with
the loop vectoriser we don't usually care about any CHECK lines
generated for the scalar tail of the loop, since the scalar
loop is kept intact. Previously if you wanted to eliminate such
unwanted CHECK lines you had to run the update script, then
manually delete all the lines corresponding to the scalar loop.
This can be very time consuming if the tests ever need changing.

What I've tried to do here is add a new --filter-out-after
option alongside the existing --filter* options that provides
support for stopping the generation of any CHECK lines beyond
the line that matches the filter. With the existing filter
options we never generate CHECK-NEXT lines, but we still care
about ordering with --filter-out-after so I've amended the
code to ensure we treat this filter differently.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list