[all-commits] [llvm/llvm-project] 3f3e4c: Support: Fix program error test failures when usin...

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/issue129208/fix-process-error-tests-when-using-fork
  Home:   https://github.com/llvm/llvm-project
  Commit: 3f3e4c72639f138ab7b6c01125ec954314478e90
      https://github.com/llvm/llvm-project/commit/3f3e4c72639f138ab7b6c01125ec954314478e90
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-03-02 (Sun, 02 Mar 2025)

  Changed paths:
    M llvm/lib/Support/Program.cpp
    M llvm/unittests/Support/ProgramTest.cpp

  Log Message:
  -----------
  Support: Fix program error test failures when using fork

The actual exec error will not be immediate in the parent when
using the fork path. The error will manifest on the wait. The
ExecuteNoWait test was also expecting the immediate wait.

I hacked up the exit value ExecutionFailed value in ExecuteAndWait,
although arguably the previous behavior was correct. I'm not sure
what the point of the argument is, it's redundant with the return code.

Fixes #129208


  Commit: 30daa7a95f21f2d2b12a0f5d2c7ba48d38c9359f
      https://github.com/llvm/llvm-project/commit/30daa7a95f21f2d2b12a0f5d2c7ba48d38c9359f
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-03-02 (Sun, 02 Mar 2025)

  Changed paths:
    M llvm/lib/Support/Program.cpp
    M llvm/unittests/Support/ProgramTest.cpp

  Log Message:
  -----------
  Revert fixing up ExecutionFailed, remove the test for ExecutionFailed instead


Compare: https://github.com/llvm/llvm-project/compare/acaac0ba0673...30daa7a95f21

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications