[all-commits] [llvm/llvm-project] acaac0: Support: Fix program error test failures when usin...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Sat Mar 1 18:31:57 PST 2025


  Branch: refs/heads/users/arsenm/issue129208/fix-process-error-tests-when-using-fork
  Home:   https://github.com/llvm/llvm-project
  Commit: acaac0ba0673ef03aaece514191c5b547610e753
      https://github.com/llvm/llvm-project/commit/acaac0ba0673ef03aaece514191c5b547610e753
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-03-02 (Sun, 02 Mar 2025)

  Changed paths:
    M llvm/lib/Support/Program.cpp
    M llvm/unittests/Support/ProgramTest.cpp

  Log Message:
  -----------
  Support: Fix program error test failures when using fork

The actual exec error will not be immediate in the parent when
using the fork path. The error will manifest on the wait. The
ExecuteNoWait test was also expecting the immediate wait.

I hacked up the exit value ExecutionFailed value in ExecuteAndWait,
although arguably the previous behavior was correct. I'm not sure
what the point of the argument is, it's redundant with the return code.

Fixes #129208



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list