[all-commits] [llvm/llvm-project] f161b1: [libc++][test] Refactor tests for rotate and rotat...

Peng Liu via All-commits all-commits at lists.llvm.org
Wed Feb 26 08:58:18 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f161b1b5265baadc443506b88bd1084adccaef90
      https://github.com/llvm/llvm-project/commit/f161b1b5265baadc443506b88bd1084adccaef90
  Author: Peng Liu <winner245 at hotmail.com>
  Date:   2025-02-26 (Wed, 26 Feb 2025)

  Changed paths:
    M libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/pstl.rotate_copy.pass.cpp
    M libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/ranges.rotate_copy.pass.cpp
    M libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/ranges_rotate.pass.cpp
    M libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/rotate.pass.cpp
    M libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/rotate_copy.pass.cpp

  Log Message:
  -----------
  [libc++][test] Refactor tests for rotate and rotate_copy (#126458)

This PR refactors the tests and fix some problems:  
- Refactor similar tests using `types::for_each` to remove redundant code;
- Explicitly include the missing header `type_algorithms.h` instead of relying
  on a transitive include;
- Fix the incorrect constexpr declaration in `rotate.pass.cpp`, where
  the `test()` function is incorrectly defined as `TEST_CONSTEXPR_CXX17`,
  which is wrong since `std::rotate()` becomes constexpr only since C++20.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list