[all-commits] [llvm/llvm-project] 7c104b: [mlir] Introduce OpAsmAttrInterface for pretty-pri...

[Hongren Zheng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7c104b63c7aae66cf91fa65b04011c49641b456d
      https://github.com/llvm/llvm-project/commit/7c104b63c7aae66cf91fa65b04011c49641b456d
  Author: Hongren Zheng <i at zenithal.me>
  Date:   2025-02-19 (Wed, 19 Feb 2025)

  Changed paths:
    M mlir/include/mlir/IR/CMakeLists.txt
    M mlir/include/mlir/IR/OpAsmInterface.td
    M mlir/include/mlir/IR/OpImplementation.h
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/test/IR/op-asm-interface.mlir
    M mlir/test/lib/Dialect/Test/TestAttrDefs.td
    M mlir/test/lib/Dialect/Test/TestAttributes.cpp

  Log Message:
  -----------
  [mlir] Introduce OpAsmAttrInterface for pretty-print (#124721)

See
https://discourse.llvm.org/t/rfc-introduce-opasm-type-attr-interface-for-pretty-print-in-asmprinter/83792
for detailed introduction.

This PR adds

* Definition of `OpAsmAttrInterface`
* Integration of `OpAsmAttrInterface` with `AsmPrinter`

In
https://github.com/llvm/llvm-project/pull/121187#discussion_r1931472250
I mentioned splitting them into two PRs, but I realized that a PR with
only definition of `OpAsmAttrInterface` is hard to test as it requires a
custom Dialect with `OpAsmDialectInterface` to hook with `AsmPrinter`,
so I just put them together to have a e2e test.

Cc @River707 @jpienaar @ftynse for review.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications