[all-commits] [llvm/llvm-project] 055872: [mlir] Integrate OpAsmTypeInterface with AsmPrinte...

Hongren Zheng via All-commits all-commits at lists.llvm.org
Tue Feb 18 10:07:40 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 055872acc28afdd8d29acdbec24f4bd415481d33
      https://github.com/llvm/llvm-project/commit/055872acc28afdd8d29acdbec24f4bd415481d33
  Author: Hongren Zheng <i at zenithal.me>
  Date:   2025-02-19 (Wed, 19 Feb 2025)

  Changed paths:
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/test/IR/op-asm-interface.mlir
    M mlir/test/lib/Dialect/Test/TestOps.td

  Log Message:
  -----------
  [mlir] Integrate OpAsmTypeInterface with AsmPrinter (#124700)

See
https://discourse.llvm.org/t/rfc-introduce-opasm-type-attr-interface-for-pretty-print-in-asmprinter/83792
for detailed introduction.

This is a follow up PR of #121187, by integrating OpAsmTypeInterface
with AsmPrinter. There are a few conditions when OpAsmTypeInterface
comes into play

* There is no OpAsmOpInterface
* Or OpAsmOpInterface::getAsmResultName/getBlockArgumentName does not
invoke `setName` (i.e. the default impl)
* All results have OpAsmTypeInterface (otherwise we can not handle
result grouping behavior)

Cc @River707 @jpienaar @ftynse for review.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list