[all-commits] [llvm/llvm-project] e6e6c5: [MLIR][OpenMP] Add Lowering support for OpenMP Dec...

Akash Banerjee via All-commits all-commits at lists.llvm.org
Mon Feb 10 12:05:25 PST 2025


  Branch: refs/heads/users/akash/mapper_llvm_lower
  Home:   https://github.com/llvm/llvm-project
  Commit: e6e6c5cf37f240350023a25067c5dbe8fa7948a6
      https://github.com/llvm/llvm-project/commit/e6e6c5cf37f240350023a25067c5dbe8fa7948a6
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Lower/OpenMP/OpenMP.cpp
    M flang/lib/Optimizer/OpenMP/MapInfoFinalization.cpp
    M flang/test/Lower/OpenMP/Todo/omp-declare-mapper.f90
    A flang/test/Lower/OpenMP/declare-mapper.f90

  Log Message:
  -----------
  [MLIR][OpenMP] Add Lowering support for OpenMP Declare Mapper directive

This patch adds HLFIR/FIR lowering support for OpenMP Declare Mapper directive.


  Commit: 4898d26a0083adaf3ec37545a0a4f9c9db3f00da
      https://github.com/llvm/llvm-project/commit/4898d26a0083adaf3ec37545a0a4f9c9db3f00da
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/test/Lower/OpenMP/declare-mapper.f90

  Log Message:
  -----------
  Add emptyline to test.


  Commit: d549130610e8c132e681e19259cfa32e47a36b64
      https://github.com/llvm/llvm-project/commit/d549130610e8c132e681e19259cfa32e47a36b64
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Lower/OpenMP/OpenMP.cpp

  Log Message:
  -----------
  Addressed reviewer comments. Added assert to check for derived type.


  Commit: 7c46df20f37efdb5dcc5429d294e54bb9f76a040
      https://github.com/llvm/llvm-project/commit/7c46df20f37efdb5dcc5429d294e54bb9f76a040
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Lower/OpenMP/OpenMP.cpp
    M flang/lib/Optimizer/OpenMP/MapInfoFinalization.cpp
    R flang/test/Lower/OpenMP/Todo/omp-declare-mapper.f90
    M flang/test/Lower/OpenMP/declare-mapper.f90

  Log Message:
  -----------
  Add lowering changes for declMapperOp's region.


  Commit: aba8787f5aa9a0280ba0bfc05678a90d8ad1410d
      https://github.com/llvm/llvm-project/commit/aba8787f5aa9a0280ba0bfc05678a90d8ad1410d
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/include/flang/Lower/AbstractConverter.h
    M flang/lib/Lower/Bridge.cpp
    M flang/lib/Lower/OpenMP/OpenMP.cpp
    M flang/test/Lower/OpenMP/declare-mapper.f90

  Log Message:
  -----------
  Add required changes to hoist DeclareMapperOp to the ModuleOp's region.
Add a new name mangling method which accepts a user supplied scope to mangle the name, in addition to the existing function which always used the currentScope.


  Commit: e52a29aa4d60a611d06494f31cbe5d1ca8739a4a
      https://github.com/llvm/llvm-project/commit/e52a29aa4d60a611d06494f31cbe5d1ca8739a4a
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Optimizer/OpenMP/MapInfoFinalization.cpp
    M flang/test/Lower/OpenMP/declare-mapper.f90

  Log Message:
  -----------
  Update MapInfoFinalization pass to look for MapInfoOps inside DeclareMapperOps as well as inside the Module.


  Commit: 88daa53ace349de07dd945bfb806140b6cf8d300
      https://github.com/llvm/llvm-project/commit/88daa53ace349de07dd945bfb806140b6cf8d300
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Lower/OpenMP/OpenMP.cpp

  Log Message:
  -----------
  Address reviewer comments.


  Commit: ea50dad896be964c543ac2d00e5566f3476cfd21
      https://github.com/llvm/llvm-project/commit/ea50dad896be964c543ac2d00e5566f3476cfd21
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Lower/OpenMP/OpenMP.cpp
    M flang/lib/Optimizer/OpenMP/MapInfoFinalization.cpp
    M flang/test/Lower/OpenMP/declare-mapper.f90

  Log Message:
  -----------
  Addressed reviewer comments.


  Commit: 5d7a40246557b2510115104916fb9b553d9b322a
      https://github.com/llvm/llvm-project/commit/5d7a40246557b2510115104916fb9b553d9b322a
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Lower/OpenMP/OpenMP.cpp
    M flang/test/Lower/OpenMP/declare-mapper.f90

  Log Message:
  -----------
  Fix build issue.


  Commit: 95e8e2b18d9e5b35ec2ad13bd7ee58a1bd1b996d
      https://github.com/llvm/llvm-project/commit/95e8e2b18d9e5b35ec2ad13bd7ee58a1bd1b996d
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Lower/OpenMP/Utils.cpp
    M flang/lib/Lower/OpenMP/Utils.h
    M flang/lib/Optimizer/OpenMP/MapInfoFinalization.cpp
    M flang/lib/Optimizer/OpenMP/MapsForPrivatizedSymbols.cpp
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/test/Dialect/OpenMP/ops.mlir

  Log Message:
  -----------
  Add mapper field to mapInfoOp.


  Commit: e905951735750df8ad8ad711bdc77c08767171a1
      https://github.com/llvm/llvm-project/commit/e905951735750df8ad8ad711bdc77c08767171a1
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/test/Dialect/OpenMP/invalid.mlir

  Log Message:
  -----------
  Add description for mapper_id. Add verifier check for valid mapper_id.


  Commit: d7bb2309591d828756b7e1274ebcf592b992eb16
      https://github.com/llvm/llvm-project/commit/d7bb2309591d828756b7e1274ebcf592b992eb16
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Lower/OpenMP/ClauseProcessor.cpp
    M flang/lib/Lower/OpenMP/ClauseProcessor.h
    R flang/test/Lower/OpenMP/Todo/map-mapper.f90
    A flang/test/Lower/OpenMP/map-mapper.f90

  Log Message:
  -----------
  Add flang lowering changes for mapper field in map clause.


  Commit: fcd44f553ee84eebc811cc1a461d4aef7fa425dc
      https://github.com/llvm/llvm-project/commit/fcd44f553ee84eebc811cc1a461d4aef7fa425dc
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/test/Lower/OpenMP/map-mapper.f90

  Log Message:
  -----------
  Split test into two separate directives.


  Commit: 003adfa6d527749a956fd483d424ca09edabddb0
      https://github.com/llvm/llvm-project/commit/003adfa6d527749a956fd483d424ca09edabddb0
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Lower/OpenMP/ClauseProcessor.cpp

  Log Message:
  -----------
  Address reviewer comments.


  Commit: c5b4f50e130853b20698b4c1b2f55b9c49eae2fd
      https://github.com/llvm/llvm-project/commit/c5b4f50e130853b20698b4c1b2f55b9c49eae2fd
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/lib/Lower/OpenMP/ClauseProcessor.cpp
    M flang/lib/Lower/OpenMP/ClauseProcessor.h

  Log Message:
  -----------
  Replace std:string with llvm::StringRef


  Commit: 14e666593f9966b24f11602104788c3501364574
      https://github.com/llvm/llvm-project/commit/14e666593f9966b24f11602104788c3501364574
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/test/Fir/convert-to-llvm-openmp-and-fir.fir
    M mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp
    M mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir

  Log Message:
  -----------
  Add OpenMP to LLVM dialect conversion support for DeclareMapperOp.


  Commit: af3dcbfd2a577009cc68e18a246f9d25f6b951ad
      https://github.com/llvm/llvm-project/commit/af3dcbfd2a577009cc68e18a246f9d25f6b951ad
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M flang/test/Fir/convert-to-llvm-openmp-and-fir.fir
    M mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp
    M mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir

  Log Message:
  -----------
  Address reviewer comments.


  Commit: 66fe4f9aa58d284967668dacc781e34a4816cc82
      https://github.com/llvm/llvm-project/commit/66fe4f9aa58d284967668dacc781e34a4816cc82
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M clang/lib/CodeGen/CGOpenMPRuntime.cpp
    M llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
    M llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
    M llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Target/LLVMIR/omptarget-llvm.mlir
    A offload/test/offloading/fortran/target-custom-mapper.f90

  Log Message:
  -----------
  [MLIR][OpenMP] Add LLVM translation support for OpenMP UserDefinedMappers

This patch adds OpenMPToLLVMIRTranslation support for the OpenMP Declare Mapper directive.

Since both MLIR and Clang now support custom mappers, I've made the relative params required instead of optional as well.

Depends on #121005


  Commit: 4aa1c5dc00552e5d9f6d529affa4fe5241210e14
      https://github.com/llvm/llvm-project/commit/4aa1c5dc00552e5d9f6d529affa4fe5241210e14
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp

  Log Message:
  -----------
  Fix IRBuilderTest failure.


  Commit: 06fc073841e060a4d4e9fb512b02075bfbc48305
      https://github.com/llvm/llvm-project/commit/06fc073841e060a4d4e9fb512b02075bfbc48305
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M offload/test/offloading/fortran/target-custom-mapper.f90

  Log Message:
  -----------
  Address reviewer comments.


  Commit: c476644ad330a469f74c8326afc2cf92b166c270
      https://github.com/llvm/llvm-project/commit/c476644ad330a469f74c8326afc2cf92b166c270
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Target/LLVMIR/omptarget-llvm.mlir

  Log Message:
  -----------
  Address reviewer comments.


  Commit: 8a0192d46d167e3d29a88a0f683bab3b9a55ced9
      https://github.com/llvm/llvm-project/commit/8a0192d46d167e3d29a88a0f683bab3b9a55ced9
  Author: Akash Banerjee <Akash.Banerjee at amd.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M clang/lib/CodeGen/CGOpenMPRuntime.cpp
    M llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
    M llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

  Log Message:
  -----------
  Address reviewer comments.


Compare: https://github.com/llvm/llvm-project/compare/6d74d0f2c8af...8a0192d46d16

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list