[all-commits] [llvm/llvm-project] f147d6: [X86] Use StackArgTokenFactor for all stores when ...

[Florian Hahn via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f147d67524d734212eb36f01db453606f70bece5
      https://github.com/llvm/llvm-project/commit/f147d67524d734212eb36f01db453606f70bece5
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLoweringCall.cpp
    M llvm/test/CodeGen/X86/swifttailcc-store-ret-address-aliasing-stack-slot.ll

  Log Message:
  -----------
  [X86] Use StackArgTokenFactor for all stores when setting up tail calls. (#126244)

Before this patch, the stack argument token factor was used if any
outgoing stack slots needed to be written, but not when writing the
return address to a stack slot. Writing the return address stack slot
can also alias a stack slot for an input argument.

Always use StackArgumentTokenFactor, to ensure the store of the return
address will always use it, i.e. happen after all input arguments are
loaded.

PR: https://github.com/llvm/llvm-project/pull/126244



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications