[all-commits] [llvm/llvm-project] fb5408: DAG: Avoid forming shufflevector from a single ext...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Wed Jan 15 23:56:23 PST 2025


  Branch: refs/heads/users/arsenm/dag-do-not-form-shuffle-for-single-extract-element
  Home:   https://github.com/llvm/llvm-project
  Commit: fb5408572e974346002841248f5d2a93aad8702b
      https://github.com/llvm/llvm-project/commit/fb5408572e974346002841248f5d2a93aad8702b
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-15 (Wed, 15 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
    M llvm/test/CodeGen/X86/avx512-build-vector.ll
    M llvm/test/CodeGen/X86/insertelement-duplicates.ll
    M llvm/test/CodeGen/X86/sse-align-12.ll

  Log Message:
  -----------
  DAG: Avoid forming shufflevector from a single extract_vector_elt

This avoids regressions in a future AMDGPU commit. Previously we
would have a build_vector (extract_vector_elt x), undef with free
access to the elements bloated into a shuffle of one element + undef,
which has much worse combine support than the extract.

Alternatively could check aggressivelyPreferBuildVectorSources, but
I'm not sure it's really different than isExtractVecEltCheap.


  Commit: 135a7ea88bdc59ac0a90375db212c1762e4f4536
      https://github.com/llvm/llvm-project/commit/135a7ea88bdc59ac0a90375db212c1762e4f4536
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
    M llvm/test/CodeGen/X86/avx512-build-vector.ll
    M llvm/test/CodeGen/X86/sse-align-12.ll

  Log Message:
  -----------
  Check hasOneUse on the source vector. This gives up some of the x86 improvements


  Commit: 932a1b60b04897d5e54d164eaa59a1113ec4f6ba
      https://github.com/llvm/llvm-project/commit/932a1b60b04897d5e54d164eaa59a1113ec4f6ba
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast_from_memory.ll
    M llvm/test/CodeGen/X86/buildvec-extract.ll
    M llvm/test/CodeGen/X86/insertelement-duplicates.ll
    M llvm/test/CodeGen/X86/movmsk-bittest.ll
    M llvm/test/CodeGen/X86/split-extend-vector-inreg.ll
    M llvm/test/CodeGen/X86/sse41.ll
    M llvm/test/CodeGen/X86/vec_extract-avx.ll
    M llvm/test/CodeGen/X86/vector-interleaved-store-i32-stride-5.ll
    M llvm/test/CodeGen/X86/vector-narrow-binop.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast_from_memory.ll

  Log Message:
  -----------
  Count the number of extract uses


  Commit: 7a1aa16d928e8b932c6a7e6ff7598b7f13d1af9b
      https://github.com/llvm/llvm-project/commit/7a1aa16d928e8b932c6a7e6ff7598b7f13d1af9b
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast_from_memory.ll
    M llvm/test/CodeGen/X86/buildvec-extract.ll
    M llvm/test/CodeGen/X86/movmsk-bittest.ll
    M llvm/test/CodeGen/X86/split-extend-vector-inreg.ll
    M llvm/test/CodeGen/X86/sse41.ll
    M llvm/test/CodeGen/X86/vec_extract-avx.ll
    M llvm/test/CodeGen/X86/vector-interleaved-store-i32-stride-5.ll
    M llvm/test/CodeGen/X86/vector-narrow-binop.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast_from_memory.ll

  Log Message:
  -----------
  Avoid arm regressions


  Commit: 013b1aa25dc8b33c6916de532019efd91e69ee13
      https://github.com/llvm/llvm-project/commit/013b1aa25dc8b33c6916de532019efd91e69ee13
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

  Log Message:
  -----------
  Cleanup and comment


Compare: https://github.com/llvm/llvm-project/compare/cc2d6ff713c9...013b1aa25dc8

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list