[all-commits] [llvm/llvm-project] 8ab691: [Clang] Interpreter test should not depend on syst...

[Yuxuan Chen via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ab6912831277d87838518c5f775f79d14616860
      https://github.com/llvm/llvm-project/commit/8ab6912831277d87838518c5f775f79d14616860
  Author: Yuxuan Chen <ych at fb.com>
  Date:   2024-12-13 (Fri, 13 Dec 2024)

  Changed paths:
    A clang/test/Interpreter/Inputs/vector
    M clang/test/Interpreter/crash.cpp

  Log Message:
  -----------
  [Clang] Interpreter test should not depend on system header (#119903)

https://github.com/llvm/llvm-project/commit/30ad53b92cec0cff9679d559edcc5b933312ba0c
introduced a new test that includes `<vector>` from the system include
path without honoring environment variables that may provide the path to
C++ standard library. This is not supported in some CI systems because
we don't always have the C++ library in the standard location.

The conventional way of doing includes in the test is through `Inputs`
directory and pass it as an include path.

The `vector` file included in this patch has been shortened, but I have
verified that it works with this test. i.e. the clang repl crashes on
this test in the same way if the fix in
https://github.com/llvm/llvm-project/pull/117475 is reverted.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications