[all-commits] [llvm/llvm-project] ba572a: [SPIRV] Add reads from image buffer for shaders. (...

[Steven Perron via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ba572abeb4fa698d04222877d10d1c547b6c2c01
      https://github.com/llvm/llvm-project/commit/ba572abeb4fa698d04222877d10d1c547b6c2c01
  Author: Steven Perron <stevenperron at google.com>
  Date:   2024-11-12 (Tue, 12 Nov 2024)

  Changed paths:
    M llvm/docs/SPIRVUsage.rst
    M llvm/include/llvm/IR/IntrinsicsSPIRV.td
    M llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.cpp
    M llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.h
    M llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
    M llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp
    A llvm/test/CodeGen/SPIRV/hlsl-resources/BufferLoad.ll
    R llvm/test/CodeGen/SPIRV/hlsl-resources/HlslBufferLoad.ll
    A llvm/test/CodeGen/SPIRV/hlsl-resources/ScalarResourceType.ll
    A llvm/test/CodeGen/SPIRV/hlsl-resources/UnknownBufferLoad.ll
    M llvm/test/CodeGen/SPIRV/read_image.ll
    M llvm/test/CodeGen/SPIRV/transcoding/OpImageReadMS.ll

  Log Message:
  -----------
  [SPIRV] Add reads from image buffer for shaders. (#115178)

This commit adds an intrinsic that will read from an image buffer. We
chose to match the name of the DXIL intrinsic for simplicity in clang.

We cannot reuse the existing openCL readimage function because that is
not a reserved name in HLSL.

I considered trying to refactor generateReadImageInst, so that we could
share code between the two implementations. However, most of the code in
generateReadImageInst is concerned with trying to figure out which type
of image read is being done. Once we factor out the code that will be
common, then we end up with just a single call to the MIRBuilder being
common.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications