[all-commits] [llvm/llvm-project] 8129b6: [NVPTX, InstCombine] instcombine known pointer AS ...

[Artem Belevich via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8129b6b53bf5a8f0cc2124764935761e74bbb5c8
      https://github.com/llvm/llvm-project/commit/8129b6b53bf5a8f0cc2124764935761e74bbb5c8
  Author: Artem Belevich <tra at google.com>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    A llvm/include/llvm/Support/NVPTXAddrSpace.h
    M llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXBaseInfo.h
    M llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp
    A llvm/test/Transforms/InstCombine/NVPTX/isspacep.ll

  Log Message:
  -----------
  [NVPTX, InstCombine] instcombine known pointer AS checks. (#114325)

The change improves the code in general and, as a side effect, avoids
crashing on an impossible address space casts guarded 
by `__isGlobal/__isShared`, which partially fixes 
https://github.com/llvm/llvm-project/issues/112760

It's still possible to trigger the issue by using explicit AS casts w/o
AS checks, but LLVM should no longer crash on valid code.

This is #112964 + a small fix for the crash on unintended argument
access which was the root cause to revers the earlier version of the patch.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications