[all-commits] [llvm/llvm-project] 7dbbd2: Fix call site breakpoint patch (#114158)

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7dbbd2b251412b7b0809aabe672f3f57f0805dbb
      https://github.com/llvm/llvm-project/commit/7dbbd2b251412b7b0809aabe672f3f57f0805dbb
  Author: jimingham <jingham at apple.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    M lldb/include/lldb/Breakpoint/BreakpointLocation.h
    M lldb/include/lldb/Breakpoint/BreakpointSite.h
    M lldb/include/lldb/Core/Declaration.h
    M lldb/include/lldb/Target/StopInfo.h
    M lldb/include/lldb/Target/ThreadPlanStepInRange.h
    M lldb/source/Breakpoint/BreakpointLocation.cpp
    M lldb/source/Breakpoint/BreakpointResolver.cpp
    M lldb/source/Breakpoint/BreakpointSite.cpp
    M lldb/source/Core/Declaration.cpp
    M lldb/source/Symbol/Block.cpp
    M lldb/source/Symbol/CompileUnit.cpp
    M lldb/source/Target/StackFrameList.cpp
    M lldb/source/Target/StopInfo.cpp
    M lldb/source/Target/Thread.cpp
    M lldb/source/Target/ThreadPlanStepInRange.cpp
    M lldb/source/Target/ThreadPlanStepOverRange.cpp
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py
    M lldb/test/API/functionalities/inline-stepping/TestInlineStepping.py
    M lldb/test/API/functionalities/inline-stepping/calling.cpp

  Log Message:
  -----------
  Fix call site breakpoint patch (#114158)

This fixes the two test suite failures that I missed in the PR:

https://github.com/llvm/llvm-project/pull/112939

One was a poorly written test case - it assumed that on connect to a
gdb-remote with a running process, lldb MUST have fetched all the frame
0 registers. In fact, there's no need for it to do so (as the CallSite
patch showed...) and if we don't need to we shouldn't. So I fixed the
test to only expect a `g` packet AFTER calling read_registers.

The other was a place where some code had used 0 when it meant
LLDB_INVALID_LINE_NUMBER, which I had fixed but missed one place where
it was still compared to 0.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications