[all-commits] [llvm/llvm-project] 9cd30b: Fix the sort function for languages to have "stric...

jimingham via All-commits all-commits at lists.llvm.org
Wed Oct 30 09:26:59 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9cd30b1ef311edb0aa0527bead52e2fc490160ef
      https://github.com/llvm/llvm-project/commit/9cd30b1ef311edb0aa0527bead52e2fc490160ef
  Author: jimingham <jingham at apple.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    M lldb/source/Commands/CommandObjectType.cpp

  Log Message:
  -----------
  Fix the sort function for languages to have "strict weak ordering". (#114160)

If you build libstdc++ with "debug" strictness, the test
TestTypeLookup.py will assert. That's because we're calling llvm::sort
(which redirects to std::sort) with a function that doesn't obey strict
weak ordering.

The error was that when the two languages were equal, we're sometimes
returning `true` but strict weak ordering requires that always be false.

This patch just makes the function behave properly.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list