[all-commits] [llvm/llvm-project] 9120ad: Fix build break in SemaHLSL.cpp on MSVC 2022: warn...

[Daniel Paoliello via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9120adea504981dfd55ace25825f84018543d6f2
      https://github.com/llvm/llvm-project/commit/9120adea504981dfd55ace25825f84018543d6f2
  Author: Daniel Paoliello <danpao at microsoft.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M clang/lib/Sema/SemaHLSL.cpp

  Log Message:
  -----------
  Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (#112767)

Moves the existing `llvm_unreachable` statement to the bottom of the
function and changes the case statement to deliberately fall through to
it.

Build break was introduced by #111203

It was not caught by the builders as they use Visual Studio 2019,
whereas this warning only appears in 2022.

---------

Co-authored-by: Matheus Izvekov <mizvekov at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications